-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple ingestion #178
base: master
Are you sure you want to change the base?
Conversation
@techsavvyash please add unit + e2e. Need this to be tested on every commit. |
Have we switched to using PG_POOL ? @techsavvyash |
yes! The changes in this PR are ported from #101 |
added. |
checking into this, meanwhile you can refer this video: https://drive.google.com/file/d/1YOjHJCkuHzb1ttI1B_3aLSE6bRcv2waZ/view?usp=share_link |
@tushar5526 checked on gitpod, not able to reproduce the error mentioned, can you share the steps you followed.
DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:5432/postgres?sslmode=disable"
DB_USERNAME="timescaledb"
DB_HOST="localhost"
DB_NAME="postgres"
DB_PASSWORD="postgrespassword"
DB_PORT="5432"
and everything worked fine for me. |
@tushar5526 please review this. |
LGTM, great work @techsavvyash! Thanks |
Pull Request Test Coverage Report for Build 6693125896
💛 - Coveralls |
Works great! Thanks @techsavvyash! |
…navailable files during `ingest-data`
I still see some errors while testing @techsavvyash |
); | ||
}); | ||
} else { | ||
console.error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the default logger instead of console?
Error: ENOENT: no such file or directory, stat './ingest/programs/diksha/linkedqrcount-event.data.csv'
at Object.stat (node:internal/fs/sync:58:25)
at Object.statSync (node:fs:1669:17)
at createCompoundDatasetDataToBeInserted (/workspace/cQube-ingestion/impl/c-qube/src/services/csv-adapter/parser/dataset/dataset-grammar.helper.ts:110:20) |
I still see some errors while testing @techsavvyash I am getting no error of this sort on my local with the same ingest folder. Can you share reproduction steps? |
not able to reproduce, please share reproduction steps. |
The error reported is not being reproduced on gitpod as well for me. |
Tested again, works good. Thanks! |
ingest-data
multiple timesgrammar
files duringingest-data
processingest-data
incase the file is not present in theingest
folder during a particular run, instead of throwing an error.